lkml.org 
[lkml]   [2022]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 358/606] media: i2c/ov6650: Convert to i2c's .probe_new()
    On Fri, Nov 18, 2022 at 11:41:32PM +0100, Uwe Kleine-König wrote:
    > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    >
    > The probe function doesn't make use of the i2c_device_id * parameter so it
    > can be trivially converted.
    >
    > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

    Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

    > ---
    > drivers/media/i2c/ov6650.c | 5 ++---
    > 1 file changed, 2 insertions(+), 3 deletions(-)
    >
    > diff --git a/drivers/media/i2c/ov6650.c b/drivers/media/i2c/ov6650.c
    > index 18f041e985b7..4c0ea2ae671b 100644
    > --- a/drivers/media/i2c/ov6650.c
    > +++ b/drivers/media/i2c/ov6650.c
    > @@ -1025,8 +1025,7 @@ static const struct v4l2_subdev_internal_ops ov6650_internal_ops = {
    > /*
    > * i2c_driver function
    > */
    > -static int ov6650_probe(struct i2c_client *client,
    > - const struct i2c_device_id *did)
    > +static int ov6650_probe(struct i2c_client *client)
    > {
    > struct ov6650 *priv;
    > int ret;
    > @@ -1114,7 +1113,7 @@ static struct i2c_driver ov6650_i2c_driver = {
    > .driver = {
    > .name = "ov6650",
    > },
    > - .probe = ov6650_probe,
    > + .probe_new = ov6650_probe,
    > .remove = ov6650_remove,
    > .id_table = ov6650_id,
    > };
    > --
    > 2.38.1
    >

    --
    Regards,

    Laurent Pinchart

    \
     
     \ /
      Last update: 2022-11-19 18:46    [W:3.269 / U:0.272 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site