Messages in this thread | | | Date | Sat, 19 Nov 2022 11:38:49 -0500 | From | Johannes Weiner <> | Subject | Re: [PATCH v6 4/6] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order |
| |
On Fri, Nov 18, 2022 at 04:15:34PM -0800, Nhat Pham wrote: > This helps determines the coldest zspages as candidates for writeback. > > Signed-off-by: Nhat Pham <nphamcs@gmail.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
This looks good to me. The ifdefs are higher than usual, but in this case they actually really nicely annotate exactly which hunks need to move to zswap (as CONFIG_ZPOOL == CONFIG_ZSWAP) when we unify the LRU! zbud and z3fold don't have those helpful annotations (since they're zswap-only to begin with), which will make their conversion a bit more laborious. But zsmalloc can be a (rough) guiding template for them.
Thanks
| |