lkml.org 
[lkml]   [2022]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH AUTOSEL 6.0 18/44] ACPI: video: Add backlight=native DMI quirk for Dell G15 5515
    ACK for 6.0; this patch is appropriate for any branch which has the
    nvidia-wmi-ec-backlight driver.

    On Fri, Nov 18, 2022 at 09:10:58PM -0500, Sasha Levin wrote:
    > From: Hans de Goede <hdegoede@redhat.com>
    >
    > [ Upstream commit f46acc1efd4b5846de9fa05f966e504f328f34a6 ]
    >
    > The Dell G15 5515 has the WMI interface (and WMI call returns) expected
    > by the nvidia-wmi-ec-backlight interface. But the backlight class device
    > registered by the nvidia-wmi-ec-backlight driver does not actually work.
    >
    > The amdgpu_bl0 native GPU backlight class device does actually work,
    > add a backlight=native DMI quirk for this.
    >
    > Reported-by: Iris <pawel.js@protonmail.com>
    > Reviewed-by: Daniel Dadap <ddadap@nvidia.com>
    > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    > ---
    > Changes in v2:
    > - Add a comment that this needs to be revisited when dynamic-mux
    > support gets added (suggested by: Daniel Dadap)
    > Signed-off-by: Sasha Levin <sashal@kernel.org>
    > ---
    > drivers/acpi/video_detect.c | 14 ++++++++++++++
    > 1 file changed, 14 insertions(+)
    >
    > diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
    > index 68a566f69684..aae9261c424a 100644
    > --- a/drivers/acpi/video_detect.c
    > +++ b/drivers/acpi/video_detect.c
    > @@ -578,6 +578,20 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
    > DMI_MATCH(DMI_BOARD_NAME, "GMxRGxx"),
    > },
    > },
    > + /*
    > + * Models which have nvidia-ec-wmi support, but should not use it.
    > + * Note this indicates a likely firmware bug on these models and should
    > + * be revisited if/when Linux gets support for dynamic mux mode.
    > + */
    > + {
    > + .callback = video_detect_force_native,
    > + /* Dell G15 5515 */
    > + .matches = {
    > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
    > + DMI_MATCH(DMI_PRODUCT_NAME, "Dell G15 5515"),
    > + },
    > + },
    > +
    > /*
    > * Desktops which falsely report a backlight and which our heuristics
    > * for this do not catch.
    > --
    > 2.35.1
    >

    \
     
     \ /
      Last update: 2022-11-19 14:31    [W:2.046 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site