Messages in this thread | | | Date | Sat, 19 Nov 2022 13:57:32 +0100 | Subject | Re: [PATCH 241/606] Input: goodix - Convert to i2c's .probe_new() | From | Hans de Goede <> |
| |
Hi,
On 11/18/22 23:39, Uwe Kleine-König wrote: > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> --- > drivers/input/touchscreen/goodix.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c > index c281e49826c2..8a0a8078de8f 100644 > --- a/drivers/input/touchscreen/goodix.c > +++ b/drivers/input/touchscreen/goodix.c > @@ -1282,8 +1282,7 @@ static void goodix_disable_regulators(void *arg) > regulator_disable(ts->avdd28); > } > > -static int goodix_ts_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int goodix_ts_probe(struct i2c_client *client) > { > struct goodix_ts_data *ts; > const char *cfg_name; > @@ -1537,7 +1536,7 @@ MODULE_DEVICE_TABLE(of, goodix_of_match); > #endif > > static struct i2c_driver goodix_ts_driver = { > - .probe = goodix_ts_probe, > + .probe_new = goodix_ts_probe, > .remove = goodix_ts_remove, > .id_table = goodix_ts_id, > .driver = {
| |