lkml.org 
[lkml]   [2022]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH V8 RESEND 3/4] PCI: vmd: Create feature grouping for client products
    From


    On 11/18/22 6:14 PM, David E. Box wrote:
    > Simplify the device ID list by creating a grouping of features shared by
    > client products.
    >
    > Suggested-by: Jon Derrick <jonathan.derrick@linux.dev>
    > Signed-off-by: David E. Box <david.e.box@linux.intel.com>
    > ---
    >

    Looks good to me.

    Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

    > V8 - New patch.
    >
    > drivers/pci/controller/vmd.c | 28 ++++++++++------------------
    > 1 file changed, 10 insertions(+), 18 deletions(-)
    >
    > diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
    > index 9dedca714c18..86f3085db014 100644
    > --- a/drivers/pci/controller/vmd.c
    > +++ b/drivers/pci/controller/vmd.c
    > @@ -68,6 +68,10 @@ enum vmd_features {
    > VMD_FEAT_CAN_BYPASS_MSI_REMAP = (1 << 4),
    > };
    >
    > +#define VMD_FEATS_CLIENT (VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP | \
    > + VMD_FEAT_HAS_BUS_RESTRICTIONS | \
    > + VMD_FEAT_OFFSET_FIRST_VECTOR)
    > +
    > static DEFINE_IDA(vmd_instance_ida);
    >
    > /*
    > @@ -1001,29 +1005,17 @@ static const struct pci_device_id vmd_ids[] = {
    > VMD_FEAT_HAS_BUS_RESTRICTIONS |
    > VMD_FEAT_CAN_BYPASS_MSI_REMAP,},
    > {PCI_VDEVICE(INTEL, 0x467f),
    > - .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP |
    > - VMD_FEAT_HAS_BUS_RESTRICTIONS |
    > - VMD_FEAT_OFFSET_FIRST_VECTOR,},
    > + .driver_data = VMD_FEATS_CLIENT,},
    > {PCI_VDEVICE(INTEL, 0x4c3d),
    > - .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP |
    > - VMD_FEAT_HAS_BUS_RESTRICTIONS |
    > - VMD_FEAT_OFFSET_FIRST_VECTOR,},
    > + .driver_data = VMD_FEATS_CLIENT,},
    > {PCI_VDEVICE(INTEL, 0xa77f),
    > - .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP |
    > - VMD_FEAT_HAS_BUS_RESTRICTIONS |
    > - VMD_FEAT_OFFSET_FIRST_VECTOR,},
    > + .driver_data = VMD_FEATS_CLIENT,},
    > {PCI_VDEVICE(INTEL, 0x7d0b),
    > - .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP |
    > - VMD_FEAT_HAS_BUS_RESTRICTIONS |
    > - VMD_FEAT_OFFSET_FIRST_VECTOR,},
    > + .driver_data = VMD_FEATS_CLIENT,},
    > {PCI_VDEVICE(INTEL, 0xad0b),
    > - .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP |
    > - VMD_FEAT_HAS_BUS_RESTRICTIONS |
    > - VMD_FEAT_OFFSET_FIRST_VECTOR,},
    > + .driver_data = VMD_FEATS_CLIENT,},
    > {PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_VMD_9A0B),
    > - .driver_data = VMD_FEAT_HAS_MEMBAR_SHADOW_VSCAP |
    > - VMD_FEAT_HAS_BUS_RESTRICTIONS |
    > - VMD_FEAT_OFFSET_FIRST_VECTOR,},
    > + .driver_data = VMD_FEATS_CLIENT,},
    > {0,}
    > };
    > MODULE_DEVICE_TABLE(pci, vmd_ids);

    --
    Sathyanarayanan Kuppuswamy
    Linux Kernel Developer

    \
     
     \ /
      Last update: 2022-11-19 06:47    [W:3.796 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site