Messages in this thread | | | Date | Fri, 18 Nov 2022 22:27:11 +0900 | From | Yuma Ueda <> | Subject | Re: [PATCH v2] scripts/kallsyms.c Make the comment up-to-date with current implementation |
| |
Thank you for your comment.
On Wed, Nov 16, 2022 at 09:04:22PM +0100, Miguel Ojeda wrote: > On Tue, Nov 15, 2022 at 10:26 PM Yuma Ueda <cyan@0x00a1e9.dev> wrote: > > > > The comment in scripts/kallsyms.c describing the usage of > > scripts/kallsyms does not reflect the latest implementation. > > Fix the comment to be up-to-date with the current implementation. > > It may be a good idea to say in the commit message that this is now > equivalent to what the `usage()` function prints (and possibly change > `scripts/kallsyms` to just `kallsyms` to make it exactly equal).
I'll change it that way for both.
> In fact, we could replace the comment with "See usage() function" to > avoid further desyncs... But that is a different patch :) >
I don't know if the comment should just be changed to "See usage() function", and as you said, that should be done in a different patch, so for now I will send a patch that fixes the issues you mentioned.
> Also, I am not sure we want to use tabs on the comment -- the rest of > it uses spaces.
OK, I'll change tabs into spaces.
> > Cheers, > Miguel
I'll send a new version of the patch later.
Regards,
Yuma Ueda
| |