lkml.org 
[lkml]   [2022]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 6.0 31/44] nvme: quiet user passthrough command errors
    Date
    From: Keith Busch <kbusch@kernel.org>

    [ Upstream commit d7ac8dca938cd60cf7bd9a89a229a173c6bcba87 ]

    The driver is spamming the kernel logs for entirely harmless errors from
    user space submitting unsupported commands. Just silence the errors.
    The application has direct access to command status, so there's no need
    to log these.

    And since every passthrough command now uses the quiet flag, move the
    setting to the common initializer.

    Signed-off-by: Keith Busch <kbusch@kernel.org>
    Reviewed-by: Alan Adamson <alan.adamson@oracle.com>
    Reviewed-by: Jens Axboe <axboe@kernel.dk>
    Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>
    Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
    Reviewed-by: Daniel Wagner <dwagner@suse.de>
    Tested-by: Alan Adamson <alan.adamson@oracle.com>
    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/nvme/host/core.c | 3 +--
    drivers/nvme/host/pci.c | 2 --
    2 files changed, 1 insertion(+), 4 deletions(-)

    diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
    index ed47c256dbd2..01c36284e542 100644
    --- a/drivers/nvme/host/core.c
    +++ b/drivers/nvme/host/core.c
    @@ -675,6 +675,7 @@ void nvme_init_request(struct request *req, struct nvme_command *cmd)
    if (req->mq_hctx->type == HCTX_TYPE_POLL)
    req->cmd_flags |= REQ_POLLED;
    nvme_clear_nvme_request(req);
    + req->rq_flags |= RQF_QUIET;
    memcpy(nvme_req(req)->cmd, cmd, sizeof(*cmd));
    }
    EXPORT_SYMBOL_GPL(nvme_init_request);
    @@ -1037,7 +1038,6 @@ int __nvme_submit_sync_cmd(struct request_queue *q, struct nvme_command *cmd,
    goto out;
    }

    - req->rq_flags |= RQF_QUIET;
    ret = nvme_execute_rq(req, at_head);
    if (result && ret >= 0)
    *result = nvme_req(req)->result;
    @@ -1225,7 +1225,6 @@ static void nvme_keep_alive_work(struct work_struct *work)
    rq->timeout = ctrl->kato * HZ;
    rq->end_io = nvme_keep_alive_end_io;
    rq->end_io_data = ctrl;
    - rq->rq_flags |= RQF_QUIET;
    blk_execute_rq_nowait(rq, false);
    }

    diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
    index 554468ea5a2a..73c464d68777 100644
    --- a/drivers/nvme/host/pci.c
    +++ b/drivers/nvme/host/pci.c
    @@ -1438,7 +1438,6 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req)

    abort_req->end_io = abort_endio;
    abort_req->end_io_data = NULL;
    - abort_req->rq_flags |= RQF_QUIET;
    blk_execute_rq_nowait(abort_req, false);

    /*
    @@ -2489,7 +2488,6 @@ static int nvme_delete_queue(struct nvme_queue *nvmeq, u8 opcode)
    req->end_io_data = nvmeq;

    init_completion(&nvmeq->delete_done);
    - req->rq_flags |= RQF_QUIET;
    blk_execute_rq_nowait(req, false);
    return 0;
    }
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-11-19 03:16    [W:4.038 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site