Messages in this thread | | | Date | Thu, 17 Nov 2022 14:54:16 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH v2 1/2] pwm: core: Refactor pwmchip_add() to avoid extra checks |
| |
On Wed, Nov 16, 2022 at 10:22:56AM +0200, Andy Shevchenko wrote: > On Tue, Nov 15, 2022 at 09:24:12PM +0100, Uwe Kleine-König wrote: > > On Mon, Nov 14, 2022 at 07:00:04PM +0200, Andy Shevchenko wrote: > > > When we already know that everything is fine there is no need > > > to use ret variable. Refactor code accordingly. > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > The patch is correct (i.e. doesn't change the semantic of the function). > > > > But I think there is some more potential to clean up than it used here. > > I will send out a series that I like better than this patch. > > Fine, can you attach the second patch of this series to yours v2, please?
These are independant cleanups. I suggest that Thierry just picks up the other patch in this series (assuming of course he is OK with it).
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |