lkml.org 
[lkml]   [2022]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH 3/4] memory-failure: Convert truncate_error_page() to use folio
Date
On Tue, Nov 15, 2022 at 06:10:10PM -0800, Vishal Moola (Oracle) wrote:
> Replaces try_to_release_page() with filemap_release_folio(). This change
> is in preparation for the removal of the try_to_release_page() wrapper.
>
> Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>

Looks good to me, thank you.

Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>

> ---
> mm/memory-failure.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 145bb561ddb3..92ec9b0e58a3 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -827,12 +827,13 @@ static int truncate_error_page(struct page *p, unsigned long pfn,
> int ret = MF_FAILED;
>
> if (mapping->a_ops->error_remove_page) {
> + struct folio *folio = page_folio(p);
> int err = mapping->a_ops->error_remove_page(mapping, p);
>
> if (err != 0) {
> pr_info("%#lx: Failed to punch page: %d\n", pfn, err);
> - } else if (page_has_private(p) &&
> - !try_to_release_page(p, GFP_NOIO)) {
> + } else if (folio_has_private(folio) &&
> + !filemap_release_folio(folio, GFP_NOIO)) {
> pr_info("%#lx: failed to release buffers\n", pfn);
> } else {
> ret = MF_RECOVERED;
> --
> 2.38.1
\
 
 \ /
  Last update: 2022-11-17 06:51    [W:0.058 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site