Messages in this thread | | | From | John Ogness <> | Subject | Re: [PATCH printk v5 37/40] tty: serial: kgdboc: synchronize tty_find_polling_driver() and register_console() | Date | Thu, 17 Nov 2022 11:06:40 +0106 |
| |
On 2022-11-16, Doug Anderson <dianders@chromium.org> wrote: > Seems OK to me, though I guess I would have moved console_lock() up > too just because this isn't a case we need to optimize and then we can > be extra certain that nobody else is messing with console structures > while we're looking at them.
Actually this series is not about optimization. It is about reducing the scope of console_lock and removing unnecessary use of it.
If tty_find_polling_driver() needs to be called under the console_lock, then we need to document exactly why. I could not find any situations where it is necessary.
Also keep in mind that in the long term we will be completely removing the console_lock. It is a painful process of identifying and dismantling its scope and replacing it with multiple clearly scoped locking mechanisms.
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
Thanks.
John
| |