lkml.org 
[lkml]   [2022]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/4] dt-bindings: remoteproc: qcom: adsp: document sm8550 adsp, cdsp & mpss compatible
From
On 17/11/2022 10:22, Neil Armstrong wrote:
>>>
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + enum:
>>> + - qcom,sm8550-cdsp-pas
>>> + then:
>>> + properties:
>>> + power-domains:
>>> + items:
>>> + - description: CX power domain
>>> + - description: MXC power domain
>>> + - description: NSP power domain
>>> + power-domain-names:
>>> + items:
>>> + - const: cx
>>> + - const: mxc
>>> + - const: nsp
>>> +
>>
>> You also need to update entry for resets. I think it is missing.
>
> Hmm no, no resets needed for sm8550.

Indeed, only few variants update resets. I'll fix them in my cleanup
series. The series conflict with this one here.

https://lore.kernel.org/linux-arm-msm/20221116155416.164239-1-krzysztof.kozlowski@linaro.org/T/#t

>
>>
>>> - if:
>>> properties:
>>> compatible:
>>> @@ -573,6 +608,29 @@ allOf:
>>> properties:
>>> qcom,qmp: false
>>>
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + enum:
>>> + - qcom,sm8550-adsp-pas
>>> + - qcom,sm8550-cdsp-pas
>>> + - qcom,sm8550-mpss-pas
>>> + then:
>>> + properties:
>>> + memory-region:
>>> + minItems: 2
>>> + description:
>>> + First entry is a phandle for a reserved memory area that holds
>>> + the main Firmware for authentication, and second entry a phandle for a
>>> + reserved memory area that holds the Devicetree Firmware for authentication.
>>
>> Instead of minItems and description:
>> items:
>> - description: Main Firmware for auth....
>> - description: Devicetree Firmware....
>
> Ack
>
>>
>>> + else:
>>> + properties:
>>> + qcom,dtb-firmware-name: false
>>> +
>>> + memory-region:
>>> + maxItems: 1
>>> +
>
> I'll rebase on top of 20221116155416.164239-1-krzysztof.kozlowski@linaro.org.
>
> Seems I should perhaps add a separate qcom,sm8550-pas.yaml right, or adding the qcom,sm6350-pas.yam would be ok ?

The clocks and interrupts match qcom,sm8350-pas.yaml, but power domains
and memory region does not, so you need separate qcom,sm8550-pas.yaml file.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-11-17 10:33    [W:0.075 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site