Messages in this thread | | | Date | Thu, 17 Nov 2022 14:10:45 +0530 | Subject | Re: [PATCH v6 3/3] hwmon: (max6639) Change from pdata to dt configuration | From | Naresh Solanki <> |
| |
On 17-11-2022 01:15 pm, Uwe Kleine-König wrote: > Hello, > > On Wed, Nov 16, 2022 at 10:36:15PM +0100, Naresh Solanki wrote: >> max6639_platform_data is not used by any in-kernel driver and does not >> address the MAX6639 fans separately. >> Move to device tree configuration with explicit properties to configure >> each fan. >> >> Non-DT platform can still use this module with its default >> configuration. >> >> Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io> >> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com> > > What changed here since v5? Please either add a changelog below the > tripple-dash for a new revision, or make sure that all relevant people > get the cover letter. > > It seems you didn't address my comments for v5 :-\ Not sure what I missed but did following changes: Removed unused header max6639.h Used dev_err_probe instead, Removed of_pwm_n_cells, if condition for freq_table removed pwm_get_state & instead use pwm->state division/multiplication optimizations, indentation of freq_table,
> > Best regards > Uwe >
Thanks, Naresh
| |