lkml.org 
[lkml]   [2022]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v10 2/2] dt-bindings: pinctrl: add loongson-2 pinctrl
    From
    Date
    Hi maintainer,

    This patch has also changed recently. Please help merge it.

    Thanks,
    Yinbo.
    在 2022/11/14 上午10:49, Yinbo Zhu 写道:
    > Add the Loongson-2 pinctrl binding with DT schema format using
    > json-schema.
    >
    > Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
    > ---
    > Change in v10:
    > 1. Remove lio/uart2/uart1/carmera/dvo1/dvo0 pins resue configuration.
    > Change in v9:
    > 1. NO change, but other patch in this series patches set has
    > change.
    > Change in v8:
    > 1. NO change, but other patch in this series patches set has
    > change.
    > Change in v7:
    > 1. Add all change log information.
    > Change in v6:
    > 1. NO change, but other patch in this series patches set has
    > change.
    > Change in v5:
    > 1. Drop dependencies.
    > 2. Add spaces after '='.
    > 3. Replace string loongson2 with loongson-2 in title.
    > Change in v4:
    > 1. Replace Loongson2 with Loongson-2.
    > Change in v3:
    > 1. Drop the quotes in "pinctrl.yaml#".
    > 2. Remove the items in function node.
    > 3. Add requird node for "group" and "function" in properties.
    > Change in v2:
    > 1. Add "$ref to pinctrl.yaml".
    > 2. Put required after patternProperties.
    > 3. Add "additionalProperties: false" after '-pins$'
    > 4. Add "unevaluatedProperties: false" after 'pinmux$'
    > 5. Fixup the broken indentation in patternProperties node.
    > 6. Use 4 spaces for example indentation.
    >
    > .../pinctrl/loongson,ls2k-pinctrl.yaml | 123 ++++++++++++++++++
    > MAINTAINERS | 1 +
    > 2 files changed, 124 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/pinctrl/loongson,ls2k-pinctrl.yaml
    >
    > diff --git a/Documentation/devicetree/bindings/pinctrl/loongson,ls2k-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/loongson,ls2k-pinctrl.yaml
    > new file mode 100644
    > index 000000000000..bd8a45843566
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/pinctrl/loongson,ls2k-pinctrl.yaml
    > @@ -0,0 +1,123 @@
    > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
    > +%YAML 1.2
    > +---
    > +$id: http://devicetree.org/schemas/pinctrl/loongson,ls2k-pinctrl.yaml#
    > +$schema: http://devicetree.org/meta-schemas/core.yaml#
    > +
    > +title: Loongson-2 SoC Pinctrl Controller
    > +
    > +maintainers:
    > + - zhanghongchen <zhanghongchen@loongson.cn>
    > + - Yinbo Zhu <zhuyinbo@loongson.cn>
    > +
    > +allOf:
    > + - $ref: pinctrl.yaml#
    > +
    > +properties:
    > + compatible:
    > + const: loongson,ls2k-pinctrl
    > +
    > + reg:
    > + maxItems: 1
    > +
    > +patternProperties:
    > + '-pins$':
    > + type: object
    > +
    > + additionalProperties: false
    > +
    > + patternProperties:
    > + 'pinmux$':
    > + type: object
    > + description: node for pinctrl.
    > + $ref: pinmux-node.yaml#
    > +
    > + unevaluatedProperties: false
    > +
    > + properties:
    > + groups:
    > + description:
    > + One or more groups of pins to mux to a certain function
    > + items:
    > + enum: [gpio, sdio, can1, can0, pwm3, pwm2, pwm1, pwm0, i2c1, i2c0,
    > + nand, sata_led, i2s, hda]
    > + function:
    > + description:
    > + The function that a group of pins is muxed to
    > + enum: [gpio, sdio, can1, can0, pwm3, pwm2, pwm1, pwm0, i2c1, i2c0,
    > + nand, sata_led, i2s, hda]
    > +
    > + required:
    > + - groups
    > + - function
    > +
    > +required:
    > + - compatible
    > + - reg
    > +
    > +additionalProperties: false
    > +
    > +examples:
    > + - |
    > + pctrl: pinctrl@1fe00420 {
    > + compatible = "loongson,ls2k-pinctrl";
    > + reg = <0x1fe00420 0x18>;
    > + sdio_pins_default: sdio-pins {
    > + sdio-pinmux {
    > + groups = "sdio";
    > + function = "sdio";
    > + };
    > +
    > + sdio-det-pinmux {
    > + groups = "pwm2";
    > + function = "gpio";
    > + };
    > + };
    > +
    > + pwm1_pins_default: pwm1-pins {
    > + pinmux {
    > + groups = "pwm1";
    > + function = "pwm1";
    > + };
    > + };
    > +
    > + pwm0_pins_default: pwm0-pins {
    > + pinmux {
    > + groups = "pwm0";
    > + function = "pwm0";
    > + };
    > + };
    > +
    > + i2c1_pins_default: i2c1-pins {
    > + pinmux {
    > + groups = "i2c1";
    > + function = "i2c1";
    > + };
    > + };
    > +
    > + i2c0_pins_default: i2c0-pins {
    > + pinmux {
    > + groups = "i2c0";
    > + function = "i2c0";
    > + };
    > + };
    > +
    > + nand_pins_default: nand-pins {
    > + pinmux {
    > + groups = "nand";
    > + function = "nand";
    > + };
    > + };
    > +
    > + hda_pins_default: hda-pins {
    > + grp0-pinmux {
    > + groups = "hda";
    > + function = "hda";
    > + };
    > +
    > + grp1-pinmux {
    > + groups = "i2s";
    > + function = "gpio";
    > + };
    > + };
    > + };
    > diff --git a/MAINTAINERS b/MAINTAINERS
    > index 0e493b4d6e39..e85b0c1aeebb 100644
    > --- a/MAINTAINERS
    > +++ b/MAINTAINERS
    > @@ -12041,6 +12041,7 @@ M: zhanghongchen <zhanghongchen@loongson.cn>
    > M: Yinbo Zhu <zhuyinbo@loongson.cn>
    > L: linux-gpio@vger.kernel.org
    > S: Maintained
    > +F: Documentation/devicetree/bindings/pinctrl/loongson,ls2k-pinctrl.yaml
    > F: drivers/pinctrl/pinctrl-loongson2.c
    >
    > LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI)
    >

    \
     
     \ /
      Last update: 2022-11-17 08:53    [W:4.253 / U:1.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site