Messages in this thread | | | Date | Thu, 17 Nov 2022 13:38:01 -0600 | From | Bjorn Helgaas <> | Subject | Re: [PATCH v2 2/2] PCI: Allow building CONFIG_OF drivers with COMPILE_TEST |
| |
On Thu, Nov 17, 2022 at 09:55:08AM +0100, Geert Uytterhoeven wrote: > On Wed, Nov 16, 2022 at 9:51 PM Bjorn Helgaas <helgaas@kernel.org> wrote: > > From: Bjorn Helgaas <bhelgaas@google.com>
> > config PCI_HISI > > - depends on OF && (ARM64 || COMPILE_TEST) > > bool "HiSilicon Hip05 and Hip06 SoCs PCIe controllers" > > + depends on ARM64 || COMPILE_TEST > > + depends on OF || COMPILE_TEST > > Note that ARM64 selects OF, so this (and a few others) could be > simplified by dropping the "depends on OF || COMPILE_TEST". > But that might be the scope of a different patch?
Hmm, yes. I don't really know what to do here, so I left it for now. ARM64 does indeed select OF, but I'm not sure whether that's an actual arch dependency or just a convenience because most ARM64 platforms rely on it. I know there are some that use ACPI, and I don't know whether they *also* need OF.
Bjorn
| |