Messages in this thread | | | From | Ian Rogers <> | Date | Thu, 17 Nov 2022 09:16:58 -0800 | Subject | Re: [PATCH 05/12] perf test: Add 'leafloop' test workload |
| |
On Thu, Nov 17, 2022 at 8:15 AM Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > > Em Thu, Nov 17, 2022 at 01:06:16PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Nov 16, 2022 at 03:38:47PM -0800, Namhyung Kim escreveu: > > > The leafloop workload is to run an infinite loop in the test_leaf > > > function. This is needed for the ARM fp callgraph test to verify if it > > > gets the correct callchains. > > > > > > $ perf test -w leafloop > > > > On fedora:36 > > > > In file included from /usr/include/bits/libc-header-start.h:33, > > from /usr/include/stdlib.h:26, > > from tests/workloads/leafloop.c:2: > > /usr/include/features.h:412:4: error: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Werror=cpp] > > 412 | # warning _FORTIFY_SOURCE requires compiling with optimization (-O) > > | ^~~~~~~ > > cc1: all warnings being treated as errors > > make[5]: *** [/home/acme/git/perf/tools/build/Makefile.build:96: /tmp/build/perf/tests/workloads/leafloop.o] Error 1 > > make[5]: *** Waiting for unfinished jobs.... > > > > I'll try removing the _FORTIFY_SOURCE > > Works after I added this to datasym.c, leafloop.c and brstack.c:
Is there a reason we are compiling without -O ? Perhaps we can filter setting _FORTIFY_SOURCE so that it depends on -O being enabled.
Thanks, Ian
> diff --git a/tools/perf/tests/workloads/leafloop.c b/tools/perf/tests/workloads/leafloop.c > index 1bf5cc97649b0e23..5d72c001320e3013 100644 > --- a/tools/perf/tests/workloads/leafloop.c > +++ b/tools/perf/tests/workloads/leafloop.c > @@ -1,4 +1,5 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > +#undef _FORTIFY_SOURCE > #include <stdlib.h> > #include <linux/compiler.h> > #include "../tests.h"
| |