lkml.org 
[lkml]   [2022]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 17/26] drm: rcar-du: Remove #ifdef guards for PM related functions
    From
    Date
    Quoting Paul Cercueil (2022-11-07 17:52:47)
    > Use the DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to handle
    > the .suspend/.resume callbacks.
    >
    > These macros allow the suspend and resume functions to be automatically
    > dropped by the compiler when CONFIG_SUSPEND is disabled, without having
    > to use #ifdef guards.
    >
    > This has the advantage of always compiling these functions in,
    > independently of any Kconfig option. Thanks to that, bugs and other
    > regressions are subsequently easier to catch.
    >
    > Signed-off-by: Paul Cercueil <paul@crapouillou.net>

    Seems reasonable to me.

    Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

    > ---
    > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    > Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
    > Cc: linux-renesas-soc@vger.kernel.org
    > ---
    > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 9 +++------
    > 1 file changed, 3 insertions(+), 6 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
    > index a2776f1d6f2c..0a89094461cc 100644
    > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
    > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
    > @@ -599,7 +599,6 @@ static const struct drm_driver rcar_du_driver = {
    > * Power management
    > */
    >
    > -#ifdef CONFIG_PM_SLEEP
    > static int rcar_du_pm_suspend(struct device *dev)
    > {
    > struct rcar_du_device *rcdu = dev_get_drvdata(dev);
    > @@ -613,11 +612,9 @@ static int rcar_du_pm_resume(struct device *dev)
    >
    > return drm_mode_config_helper_resume(&rcdu->ddev);
    > }
    > -#endif
    >
    > -static const struct dev_pm_ops rcar_du_pm_ops = {
    > - SET_SYSTEM_SLEEP_PM_OPS(rcar_du_pm_suspend, rcar_du_pm_resume)
    > -};
    > +static DEFINE_SIMPLE_DEV_PM_OPS(rcar_du_pm_ops,
    > + rcar_du_pm_suspend, rcar_du_pm_resume);
    >
    > /* -----------------------------------------------------------------------------
    > * Platform driver
    > @@ -712,7 +709,7 @@ static struct platform_driver rcar_du_platform_driver = {
    > .shutdown = rcar_du_shutdown,
    > .driver = {
    > .name = "rcar-du",
    > - .pm = &rcar_du_pm_ops,
    > + .pm = pm_sleep_ptr(&rcar_du_pm_ops),
    > .of_match_table = rcar_du_of_table,
    > },
    > };
    > --
    > 2.35.1
    >

    \
     
     \ /
      Last update: 2022-11-16 14:43    [W:5.301 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site