Messages in this thread | | | Date | Wed, 16 Nov 2022 15:34:46 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 1/2] x86/of: Add support for boot time interrupt delivery mode configuration |
| |
On Wed, Nov 16, 2022 at 11:25:47AM +0000, Rahul Tanwar wrote: > On 16/11/2022 6:42 pm, Andy Shevchenko wrote: > > On Wed, Nov 16, 2022 at 06:28:20PM +0800, Rahul Tanwar wrote:
...
> > Why not pr_notice() in both cases? > > Reset of the file uses printk(KERN_xxx ""). In v1, i used pr_notice() > but on reviewing again found it to be odd one out in the file. So > switched to printk(KERN_xxx ""). I can revert back to using pr_notice() > if you think that's a better fit. Thanks.
I don;t know why we should use antique style of printing APIs in new patches. Even if the old code uses that, you can create a followup that can do two things: - uses pr_lvl() instead of printk(KERN_LVL) - keeps string literals unbroken between the lines (if any of such breakage exists)
-- With Best Regards, Andy Shevchenko
| |