lkml.org 
[lkml]   [2022]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/2] dt-bindings: reserved-memory: document Qualcomm MPSS DSM memory
    From
    On 16/11/2022 11:16, Neil Armstrong wrote:
    > This documents the Qualcomm Modem Processing SubSystem DSM shared memory.

    Do not use "This commit/patch".
    https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

    >
    > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
    > ---
    > .../reserved-memory/qcom,mpss-dsm-mem.yaml | 37 ++++++++++++++++++++++
    > 1 file changed, 37 insertions(+)
    >
    > diff --git a/Documentation/devicetree/bindings/reserved-memory/qcom,mpss-dsm-mem.yaml b/Documentation/devicetree/bindings/reserved-memory/qcom,mpss-dsm-mem.yaml
    > new file mode 100644
    > index 000000000000..65f37e1356d4
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/reserved-memory/qcom,mpss-dsm-mem.yaml
    > @@ -0,0 +1,37 @@
    > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
    > +%YAML 1.2
    > +---
    > +$id: "http://devicetree.org/schemas/reserved-memory/qcom,mpss-dsm-mem.yaml#"
    > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"

    Drop quotes from above.

    I know that this and few further pieces came from existing files...

    > +
    > +title: Qualcomm Modem Processing SubSystem DSM Memory
    > +
    > +description: |
    > + This binding describes the Qualcomm Modem Processing SubSystem DSM, which serves the

    Drop "This binding describes"

    > + purpose of describing the shared memory region used for MPSS remote processors.

    Entire description seems like not wrapped at 80.

    > +
    > +maintainers:
    > + - Bjorn Andersson <bjorn.andersson@linaro.org>

    Need to update the address.

    > +
    > +allOf:
    > + - $ref: "reserved-memory.yaml"

    Drop quotes.

    > +
    > +properties:
    > + compatible:
    > + const: qcom,mpss-dsm-mem

    Why do we need dedicated binding and compatible for it instead of using
    memory-region phandle in the device?

    > +
    > +unevaluatedProperties: false


    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2022-11-16 13:21    [W:6.035 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site