lkml.org 
[lkml]   [2022]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] drm/msm/dpu1: Remove INTF4 IRQ from SDM845 IRQ mask
From


On 11/7/2022 2:37 AM, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@somainline.org>
>
> SDM845 only has INTF0-3 and has no business caring about the INTF4 irq.
>
> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>

It is true that SDM845 doesnt have INTF4. I was a bit concerned whether
this would impact SM8150 as that re-uses the IRQ_SDM845_MASK but even
SM8150 doesnt have INTF4.

A minor nit, the subject convention in this file seems to be drm/msm/dpu
and not drm/msm/dpu1.

Other than that,

Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>


> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> index 27f029fdc682..06897a497eb7 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> @@ -86,7 +86,6 @@
> BIT(MDP_INTF1_INTR) | \
> BIT(MDP_INTF2_INTR) | \
> BIT(MDP_INTF3_INTR) | \
> - BIT(MDP_INTF4_INTR) | \
> BIT(MDP_AD4_0_INTR) | \
> BIT(MDP_AD4_1_INTR))
>

\
 
 \ /
  Last update: 2022-11-16 12:51    [W:0.249 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site