lkml.org 
[lkml]   [2022]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v2] PCI: dwc: use devm_request_irq to avoid missing free_irq()
Date
free_irq() is missing in ks_pcie_remove() and error path
in ks_pcie_probe(), use devm_request_irq to fix that.

Fixes: 49229238ab47 ("PCI: keystone: Cleanup PHY handling")
Signed-off-by: ruanjinjie <ruanjinjie@huawei.com>
---
v2: use devm_request_irq instead of adding free_irq() to fix the problem.
---
drivers/pci/controller/dwc/pci-keystone.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c
index 78818853af9e..25e1b3fc1877 100644
--- a/drivers/pci/controller/dwc/pci-keystone.c
+++ b/drivers/pci/controller/dwc/pci-keystone.c
@@ -1166,7 +1166,7 @@ static int __init ks_pcie_probe(struct platform_device *pdev)
if (irq < 0)
return irq;

- ret = request_irq(irq, ks_pcie_err_irq_handler, IRQF_SHARED,
+ ret = devm_request_irq(dev, irq, ks_pcie_err_irq_handler, IRQF_SHARED,
"ks-pcie-error-irq", ks_pcie);
if (ret < 0) {
dev_err(dev, "failed to request error IRQ %d\n",
--
2.25.1
\
 
 \ /
  Last update: 2022-11-16 10:56    [W:1.367 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site