Messages in this thread Patch in this message | | | Date | Wed, 16 Nov 2022 17:18:19 -0800 | From | Ira Weiny <> | Subject | Re: [PATCH 05/11] cxl/mem: Trace General Media Event Record |
| |
On Wed, Nov 16, 2022 at 03:31:06PM +0000, Jonathan Cameron wrote: > On Thu, 10 Nov 2022 10:57:52 -0800 > ira.weiny@intel.com wrote: > > > From: Ira Weiny <ira.weiny@intel.com> > > > > CXL rev 3.0 section 8.2.9.2.1.1 defines the General Media Event Record. > > > > Determine if the event read is a general media record and if so trace > > the record as a General Media Event Record. > > > > Signed-off-by: Ira Weiny <ira.weiny@intel.com> > > > A few v2.0 references left in here that should be updated given it's new code. > > With those tidied up
Fixed.
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
And thanks! Ira
> > > > diff --git a/include/trace/events/cxl.h b/include/trace/events/cxl.h > > index 60dec9a84918..a0c20e110708 100644 > > --- a/include/trace/events/cxl.h > > +++ b/include/trace/events/cxl.h > > @@ -119,6 +119,130 @@ TRACE_EVENT(cxl_generic_event, > > __print_hex(__entry->data, CXL_EVENT_RECORD_DATA_LENGTH)) > > ); > > > > +/* > > + * Physical Address field masks > > + * > > + * General Media Event Record > > + * CXL v2.0 Section 8.2.9.1.1.1; Table 154 > > Update to CXL rev 3.0 as I think we are preferring latest > spec references on any new code. > > > + * > > + * DRAM Event Record > > + * CXL rev 3.0 section 8.2.9.2.1.2; Table 8-44 > > + */ > > > + > > +/* > > + * General Media Event Record - GMER > > + * CXL v2.0 Section 8.2.9.1.1.1; Table 154 > Update ref to r3.0 > Never v or the spec folk will get irritable :) > > > + */ > > >
| |