lkml.org 
[lkml]   [2022]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v10 0/3] blk-cgroup: Optimize blkcg_rstat_flush()
From
On 11/4/22 20:58, Waiman Long wrote:
> v10:
> - Update patch 3 to rename the rstat function to
> cgroup_rstat_css_cpu_flush().
>
> v9:
> - Remove patch "llist: Allow optional sentinel node terminated lockless
> list" for now. This will be done as a follow-up patch.
> - Add a new lqueued field to blkg_iostat_set to store the status of
> whether lnode is in a lockless list.
> - Add a new patch 3 to speed up the freeing of blkcg by flushing out
> the rstat lockless lists at blkcg offline time.
>
> v8:
> - Update the llist patch to make existing llist functions and macros
> work for both NULL and sentinel terminated lockless list as much
> as possible and leave only the initialization and removal functions
> to have a sentinel terminated llist variants.
>
> This patch series improves blkcg_rstat_flush() performance by eliminating
> unnecessary blkg enumeration and flush operations for those blkg's and
> blkg_iostat_set's that haven't been updated since the last flush.
>
> Waiman Long (3):
> blk-cgroup: Return -ENOMEM directly in blkcg_css_alloc() error path
> blk-cgroup: Optimize blkcg_rstat_flush()
> blk-cgroup: Flush stats at blkgs destruction path
>
> block/blk-cgroup.c | 103 +++++++++++++++++++++++++++++++++++------
> block/blk-cgroup.h | 10 ++++
> include/linux/cgroup.h | 1 +
> kernel/cgroup/rstat.c | 20 ++++++++
> 4 files changed, 119 insertions(+), 15 deletions(-)

Jens, do you have any further comment on this patchset? Is it possible
to queue it for the next Linux version?

Cheers,
Longman

\
 
 \ /
  Last update: 2022-11-17 00:08    [W:0.079 / U:0.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site