Messages in this thread | | | From | Valentin Schneider <> | Subject | Re: [PATCH v3] cpumask: limit visibility of FORCE_NR_CPUS | Date | Wed, 16 Nov 2022 18:42:25 +0000 |
| |
On 16/11/22 09:24, Yury Norov wrote: > In current form, FORCE_NR_CPUS is visible to all users building their > kernels, even not experts. It is also set in allmodconfig or allyesconfig, > which is not a correct behavior. > > This patch fixes it. It also changes the parameter short description: > removes implementation details and highlights the effect of the change. > > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org> > Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> > Signed-off-by: Yury Norov <yury.norov@gmail.com>
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
> --- > v3: instead of 'choice', use !COMPILE_TEST to disable FORCE_NR_CPUS > in all{yes,mod}config, as suggested by Linus. > lib/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/Kconfig b/lib/Kconfig > index 9bbf8a4b2108..404647cd3fac 100644 > --- a/lib/Kconfig > +++ b/lib/Kconfig > @@ -529,8 +529,8 @@ config CPUMASK_OFFSTACK > stack overflow. > > config FORCE_NR_CPUS > - bool "NR_CPUS is set to an actual number of CPUs" > - depends on SMP > + bool "Set number of CPUs at compile time" > + depends on SMP && EXPERT && !COMPILE_TEST > help > Say Yes if you have NR_CPUS set to an actual number of possible > CPUs in your system, not to a default value. This forces the core > -- > 2.34.1
| |