lkml.org 
[lkml]   [2022]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH Part2 v6 14/49] crypto: ccp: Handle the legacy TMR allocation when SNP is enabled
    From
    On 11/16/22 02:25, Vlastimil Babka wrote:
    >> Referring back to your thoughts about putting these pages on some leaked
    >> pages list, do any such leaked pages list exist currently ?
    > Not AFAIK, you could just create a list_head somewhere appropriate (some snp
    > state structure?) and put the pages there, maybe with a counter exposed in
    > debugs. The point would be mostly that if something goes so wrong it would
    > be leaking substantial amounts of memory, we can at least recognize the
    > cause (but I suppose the dmesg will be also full of messages) and e.g. find
    > the pages in a crash dump.

    It might also be worth looking through the places that check
    PageHWPoison() and making sure that none of them are poking into the
    page contents.

    It's also the kind of thing that adding some CONFIG_DEBUG_VM checks
    might help with. For instance, nobody should ever be kmap*()'ing a
    private page. The same might even go for pin_user_pages().

    \
     
     \ /
      Last update: 2022-11-16 19:32    [W:3.930 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site