Messages in this thread | | | Date | Wed, 16 Nov 2022 16:09:43 +0000 | Subject | Re: [PATCH -next] um: vector: Fix memory leak in vector_config | From | Anton Ivanov <> |
| |
On 15/11/2022 07:32, Xiang Yang wrote: > If the return value of the uml_parse_vector_ifspec function is NULL, > we should call kfree(params) to prevent memory leak. > > Fixes: 49da7e64f33e ("High Performance UML Vector Network Driver") > Signed-off-by: Xiang Yang <xiangyang3@huawei.com> > --- > arch/um/drivers/vector_kern.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c > index ded7c47d2fbe..131b7cb29576 100644 > --- a/arch/um/drivers/vector_kern.c > +++ b/arch/um/drivers/vector_kern.c > @@ -767,6 +767,7 @@ static int vector_config(char *str, char **error_out) > > if (parsed == NULL) { > *error_out = "vector_config failed to parse parameters"; > + kfree(params); > return -EINVAL; > } >
Acked-By: Anton Ivanov <anton.ivanov@kot-begemot.co.uk> -- Anton R. Ivanov Cambridgegreys Limited. Registered in England. Company Number 10273661 https://www.cambridgegreys.com/
| |