Messages in this thread | | | Date | Wed, 16 Nov 2022 15:49:07 +0000 | From | Lee Jones <> | Subject | Re: [PATCH 1/2] mfd: ax20x: Add suppport for AXP1530 PMIC |
| |
On Mon, 14 Nov 2022, Martin Botka wrote:
> AXP1530 is a PMIC chip produced by X-Powers and an be connected via > I2C or RSB bus. > Where AXP313A seems to be closely related so the same driver can be used and > seen it only paired with H616 SoC. > > Signed-off-by: Martin Botka <martin.botka@somainline.org> > --- > drivers/mfd/axp20x-i2c.c | 2 ++ > drivers/mfd/axp20x-rsb.c | 1 + > drivers/mfd/axp20x.c | 63 ++++++++++++++++++++++++++++++++++++++ > include/linux/mfd/axp20x.h | 34 ++++++++++++++++++++ > 4 files changed, 100 insertions(+)
No major concerns.
> +static struct mfd_cell axp1530_cells[] = { > + { > + .id = 0, > + .name = "axp20x-regulator", > + }, > +};
Why .id = 0?
-- Lee Jones [李琼斯]
| |