Messages in this thread | | | Date | Wed, 16 Nov 2022 15:35:28 +0000 | From | Jonathan Cameron <> | Subject | Re: [PATCH 07/11] cxl/mem: Trace Memory Module Event Record |
| |
On Thu, 10 Nov 2022 10:57:54 -0800 ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com> > > CXL rev 3.0 section 8.2.9.2.1.3 defines the Memory Module Event Record. > > Determine if the event read is memory module record and if so trace the > record. > > Signed-off-by: Ira Weiny <ira.weiny@intel.com> > Noticed that we have a mixture of fully capitalized and not for flags. With that either explained or tidied up:
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> +/* > + * Device Health Information - DHI > + * > + * CXL res 3.0 section 8.2.9.8.3.1; Table 8-100 > + */ > +#define CXL_DHI_HS_MAINTENANCE_NEEDED BIT(0) > +#define CXL_DHI_HS_PERFORMANCE_DEGRADED BIT(1) > +#define CXL_DHI_HS_HW_REPLACEMENT_NEEDED BIT(2) > +#define show_health_status_flags(flags) __print_flags(flags, "|", \ > + { CXL_DHI_HS_MAINTENANCE_NEEDED, "Maintenance Needed" }, \ > + { CXL_DHI_HS_PERFORMANCE_DEGRADED, "Performance Degraded" }, \ > + { CXL_DHI_HS_HW_REPLACEMENT_NEEDED, "Replacement Needed" } \
Why are we sometime using capitals for flags (e.g patch 5) and not other times?
> +)
| |