Messages in this thread | | | From | Ulf Hansson <> | Date | Wed, 16 Nov 2022 16:20:51 +0100 | Subject | Re: [PATCH 1/1] mmc: sdhci: Fixed too many logs being printed during tuning |
| |
On Fri, 11 Nov 2022 at 09:42, Wenchao Chen <wenchao.chen666@gmail.com> wrote: > > From: Wenchao Chen <wenchao.chen@unisoc.com> > > During the HS200 tuning process, too many tuning errors are printed in > the log. > > Signed-off-by: Wenchao Chen <wenchao.chen@unisoc.com> > --- > drivers/mmc/host/sdhci.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c > index fef03de85b99..a503b54305eb 100644 > --- a/drivers/mmc/host/sdhci.c > +++ b/drivers/mmc/host/sdhci.c > @@ -3401,6 +3401,10 @@ static void sdhci_data_irq(struct sdhci_host *host, u32 intmask) > if (host->pending_reset) > return; > > + command = SDHCI_GET_CMD(sdhci_readw(host, SDHCI_COMMAND)); > + if (command == MMC_SEND_TUNING_BLOCK || command == MMC_SEND_TUNING_BLOCK_HS200) > + return; > +
Please use mmc_op_tuning() instead of open-coding this. I also need an ack from Adrian to apply this.
> pr_err("%s: Got data interrupt 0x%08x even though no data operation was in progress.\n", > mmc_hostname(host->mmc), (unsigned)intmask); > sdhci_err_stats_inc(host, UNEXPECTED_IRQ); > -- > 2.17.1 >
Kind regards Uffe
| |