Messages in this thread | | | Date | Tue, 15 Nov 2022 18:12:02 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH v4 1/2] net: page_pool: export page_pool_stats definition |
| |
On Tue, Nov 15, 2022 at 09:57:43AM -0600, Shenwei Wang wrote: > The definition of the 'struct page_pool_stats' is required even when > the CONFIG_PAGE_POOL_STATS is not defined. Otherwise, it is required > the drivers to handle the case of CONFIG_PAGE_POOL_STATS undefined.
I agree the API is broken, but i think there is a better fix.
There should be a stub of page_pool_get_stats() for when CONFIG_PAGE_POOL_STATS is disabled.
Nothing actually dereferences struct page_pool_stats when you have this stub. So it might be enough to simply have
struct page_pool_stats{ };
Andrew
| |