Messages in this thread | | | Date | Tue, 15 Nov 2022 18:16:57 +0200 (EET) | From | Ilpo Järvinen <> | Subject | Re: [PATCH v3 14/14] serial: liteuart: move polling putchar() function |
| |
On Sat, 12 Nov 2022, Gabriel Somlo wrote:
> The polling liteuart_putchar() function is only called from methods > conditionally enabled by CONFIG_SERIAL_LITEUART_CONSOLE. Move its > definition closer to the console code where it is dependent on the > same config option. > > Signed-off-by: Gabriel Somlo <gsomlo@gmail.com> > --- > drivers/tty/serial/liteuart.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c > index 307c27398e30..767c356e60c9 100644 > --- a/drivers/tty/serial/liteuart.c > +++ b/drivers/tty/serial/liteuart.c > @@ -69,14 +69,6 @@ static struct uart_driver liteuart_driver = { > #endif > }; > > -static void liteuart_putchar(struct uart_port *port, unsigned char ch) > -{ > - while (litex_read8(port->membase + OFF_TXFULL)) > - cpu_relax(); > - > - litex_write8(port->membase + OFF_RXTX, ch); > -} > - > static void liteuart_stop_tx(struct uart_port *port) > { > if (port->irq) { > @@ -389,6 +381,14 @@ static struct platform_driver liteuart_platform_driver = { > > #ifdef CONFIG_SERIAL_LITEUART_CONSOLE > > +static void liteuart_putchar(struct uart_port *port, unsigned char ch) > +{ > + while (litex_read8(port->membase + OFF_TXFULL)) > + cpu_relax(); > + > + litex_write8(port->membase + OFF_RXTX, ch); > +} > + > static void liteuart_console_write(struct console *co, const char *s, > unsigned int count) > {
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
-- i.
| |