Messages in this thread | | | Date | Tue, 15 Nov 2022 11:20:50 +0100 | From | Thomas Bogendoerfer <> | Subject | Re: [PATCH v2 1/2] gpio: loongson: add dts/acpi gpio support |
| |
On Tue, Nov 15, 2022 at 05:53:26PM +0800, Yinbo Zhu wrote: > > > +/* ============== Data structrues =============== */ > > > + > > > +/* gpio data */ > > > +struct platform_gpio_data { > > > + u32 gpio_conf; > > > + u32 gpio_out; > > > + u32 gpio_in; > > > + u32 support_irq; > > > + char *label; > > > + int gpio_base; > > > + int ngpio; > > > +}; > > > > No idea why you would need to duplicate it like this either. And why > > put it in arch/. > because loongson platform include mips and loongarch, and the gpio device > data was defined in arch/ in leagcy loongson gpio driver. so the > latest loongson gpio drvier add platform_gpio_data in same dir.
put the struct into a new file in include/linux/platform_data and use that.
Thomas.
-- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
| |