lkml.org 
[lkml]   [2022]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] PCI: vmd: Clean up some inconsistent indenting
Hello,

> > + if (vmd->irq_domain)
> > + vmd_set_msi_remapping(vmd, true);
> > + else
> > + vmd_set_msi_remapping(vmd, false);
>
> Why not go one step further:
>
> vmd_set_msi_remapping(vmd, !!vmd->irq_domain);

Jiapeng, if you want to get this patch merged, and it's a nice clean-up,
then apply suggestion from Christoph and send a v2, if possible.

Krzysztof

\
 
 \ /
  Last update: 2022-11-16 04:47    [W:0.045 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site