Messages in this thread | | | From | "Edgecombe, Rick P" <> | Subject | Re: [PATCH v3 27/37] x86/shstk: Introduce routines modifying shstk | Date | Tue, 15 Nov 2022 20:56:16 +0000 |
| |
On Tue, 2022-11-15 at 15:22 +0100, Peter Zijlstra wrote: > On Fri, Nov 04, 2022 at 03:35:54PM -0700, Rick Edgecombe wrote: > > +static unsigned long get_user_shstk_addr(void) > > +{ > > + unsigned long long ssp; > > + > > + fpregs_lock_and_load(); > > + > > + rdmsrl(MSR_IA32_PL3_SSP, ssp); > > + > > + fpregs_unlock(); > > + > > + return ssp; > > +} > > This doesn't return the shstk addr, unlike what the name suggests, > right?
That's a good point. get_user_ssp() would be a better name.
| |