Messages in this thread | | | Date | Tue, 15 Nov 2022 19:55:24 +0100 | Subject | Re: [PATCH v2] net: dsa: use more appropriate NET_NAME_* constants for user ports | From | Rasmus Villemoes <> |
| |
On 15/11/2022 17.38, Jakub Kicinski wrote: > On Tue, 15 Nov 2022 08:43:55 +0100 Rasmus Villemoes wrote: >> + if (port->name) { >> + name = port->name; >> + assign_type = NET_NAME_PREDICTABLE; >> + } else { >> + name = "eth%d"; >> + assign_type = NET_NAME_ENUM; > > Per Andrew's comment lets make the change in two steps. > Which one should come first is a judgment call :)
OK. I think I'll actually do it in three steps, with the first being this patch but with NET_NAME_UNKNOWN kept in both places (i.e. pure refactoring), and the latter two just changing one assign_type at a time, so they can be reverted independently.
Rasmus
| |