Messages in this thread | | | Date | Tue, 15 Nov 2022 17:31:13 +0000 | From | Sean Christopherson <> | Subject | Re: [PATCH linux-next] KVM: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE |
| |
On Tue, Nov 15, 2022, guo.ziliang@zte.com.cn wrote: > From: guo ziliang <guo.ziliang@zte.com.cn> > Fix the following coccicheck warning: > /virt/kvm/kvm_main.c: 3849: 0-23: WARNING: vcpu_get_pid_fops > should be defined with DEFINE_DEBUGFS_ATTRIBUTE > > Signed-off-by: guo ziliang <guo.ziliang@zte.com.cn> > --- > virt/kvm/kvm_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 2719e10..6e58aec 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -3846,7 +3846,7 @@ static int vcpu_get_pid(void *data, u64 *val) > return 0; > } > > -DEFINE_SIMPLE_ATTRIBUTE(vcpu_get_pid_fops, vcpu_get_pid, NULL, "%llu\n"); > ++DEFINE_DEBUGFS_ATTRIBUTE(vcpu_get_pid_fops, vcpu_get_pid, NULL, "%llu\n");
NAK, third time is not a charm.
https://lore.kernel.org/all/20221101072506.7307-1-liubo03@inspur.com https://lore.kernel.org/all/20220815031228.64126-1-ye.xingchen@zte.com.cn
| |