lkml.org 
[lkml]   [2022]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] HSI: omap_ssi_core: fix possible memory leak in ssi_probe()
Hi,

On Mon, Oct 31, 2022 at 03:43:37PM +0800, Yang Yingliang wrote:
> If ssi_add_controller() returns error, it should call hsi_put_controller()
> to give up the reference that was set in hsi_alloc_controller(), so that
> it can call hsi_controller_release() to free controller and ports that
> allocated in hsi_alloc_controller().
>
> Fixes: b209e047bc74 ("HSI: Introduce OMAP SSI driver")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---

Thanks, queued.

-- Sebastian

> drivers/hsi/controllers/omap_ssi_core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controllers/omap_ssi_core.c
> index eb9820158318..80bf09bc5d15 100644
> --- a/drivers/hsi/controllers/omap_ssi_core.c
> +++ b/drivers/hsi/controllers/omap_ssi_core.c
> @@ -502,8 +502,10 @@ static int ssi_probe(struct platform_device *pd)
> platform_set_drvdata(pd, ssi);
>
> err = ssi_add_controller(ssi, pd);
> - if (err < 0)
> + if (err < 0) {
> + hsi_put_controller(ssi);
> goto out1;
> + }
>
> pm_runtime_enable(&pd->dev);
>
> --
> 2.25.1
>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-11-14 21:51    [W:0.057 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site