lkml.org 
[lkml]   [2022]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] platform/x86: hp-wmi: Ignore Smart Experience App event
From
+Jorge Lopez @ HP

On 11/14/2022 01:38, Kai-Heng Feng wrote:
> Sometimes hp-wmi driver complains on system resume:
> [ 483.116451] hp_wmi: Unknown event_id - 33 - 0x0
>
> According to HP it's a feature called "HP Smart Experience App" and it's
> safe to be ignored.
>
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
> drivers/platform/x86/hp-wmi.c | 3 +++
> 1 file changed, 3 insertions(+)
>

Jorge,

Can you please review KH's submission?

Also to avoid playing wack-a-mole, can you cross reference your internal
specs against any other missing event IDs and send follow up patches if
anything else is missing?

Thanks,

> diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
> index 12449038bed12..0a99058be8130 100644
> --- a/drivers/platform/x86/hp-wmi.c
> +++ b/drivers/platform/x86/hp-wmi.c
> @@ -90,6 +90,7 @@ enum hp_wmi_event_ids {
> HPWMI_PEAKSHIFT_PERIOD = 0x0F,
> HPWMI_BATTERY_CHARGE_PERIOD = 0x10,
> HPWMI_SANITIZATION_MODE = 0x17,
> + HPWMI_SMART_EXPERIENCE_APP = 0x21,
> };
>
> /*
> @@ -859,6 +860,8 @@ static void hp_wmi_notify(u32 value, void *context)
> break;
> case HPWMI_SANITIZATION_MODE:
> break;
> + case HPWMI_SMART_EXPERIENCE_APP:
> + break;
> default:
> pr_info("Unknown event_id - %d - 0x%x\n", event_id, event_data);
> break;

\
 
 \ /
  Last update: 2022-11-14 21:13    [W:0.316 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site