lkml.org 
[lkml]   [2022]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 10/11] perf stat: Fix summary output in CSV with --metric-only
On Fri, Nov 11, 2022 at 7:23 PM Namhyung Kim <namhyung@kernel.org> wrote:
>
> It should not print "summary" for each event when --metric-only is set.
>
> Before:
> $ sudo perf stat -a --per-socket --summary -x, --metric-only true
> time,socket,cpusGhz,insn per cycle,branch-misses of all branches,
> 0.000709079,S0,8,0.893,2.40,0.45,
> S0,8, summary, summary, summary, summary, summary,0.893, summary,2.40, summary, summary,0.45,
>
> After:
> $ sudo perf stat -a --per-socket --summary -x, --metric-only true
> time,socket,cpusGHz,insn per cycle,branch-misses of all branches,
> 0.000882297,S0,8,0.598,1.64,0.64,
> summary,S0,8,0.598,1.64,0.64,
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
> tools/perf/util/stat-display.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index ce81798b5864..96bb7a42fd41 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -549,7 +549,7 @@ static void printout(struct perf_stat_config *config, struct aggr_cpu_id id, int
> }
>
> if (!config->no_csv_summary && config->csv_output &&
> - config->summary && !config->interval) {
> + config->summary && !config->interval && !config->metric_only) {
> fprintf(config->output, "%16s%s", "summary", config->csv_sep);
> }
>
> @@ -732,8 +732,13 @@ static void print_aggr(struct perf_stat_config *config,
> * Without each counter has its own line.
> */
> for (s = 0; s < config->aggr_map->nr; s++) {
> - if (prefix && metric_only)
> - fprintf(output, "%s", prefix);
> + if (metric_only) {
> + if (prefix)
> + fprintf(output, "%s", prefix);
> + else if (config->summary && !config->no_csv_summary &&
> + config->csv_output && !config->interval)
> + fprintf(output, "%16s%s", "summary", config->csv_sep);
> + }
>
> first = true;
> evlist__for_each_entry(evlist, counter) {
> --
> 2.38.1.493.g58b659f92b-goog
>

\
 
 \ /
  Last update: 2022-11-14 19:22    [W:0.095 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site