lkml.org 
[lkml]   [2022]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC v2 1/3] PM: Add a sysfs files to represent sleep duration
    On Thu, Nov 10, 2022 at 12:47:21AM -0600, Mario Limonciello wrote:
    > +static ssize_t last_hw_state_residency_show(struct kobject *kobj,
    > + struct kobj_attribute *attr, char *buf)
    > +{
    > + return sprintf(buf, "%llu\n", suspend_stats.last_hw_state_residency);

    sysfs_emit() please for sysfs files, not a "raw" sprintf().
    checkpatch.pl should have caught that for you, but sometimes it doesn't.

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2022-11-14 08:13    [W:8.336 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site