Messages in this thread | | | Date | Mon, 14 Nov 2022 12:17:20 +0100 | Subject | Re: [PATCH v2 1/9] dt-bindings: arm-smmu: Allow up to 3 power-domains | From | Konrad Dybcio <> |
| |
On 14/11/2022 12:01, Krzysztof Kozlowski wrote: > On 14/11/2022 11:42, Konrad Dybcio wrote: >> Some SMMUs require that a vote is held on as much as 3 separate PDs >> (hello Qualcomm). Allow it in bindings. >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> Changes since v1: >> - Add minItems >> >> Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> index 9066e6df1ba1..82bc696de662 100644 >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> @@ -159,7 +159,8 @@ properties: >> through the TCU's programming interface. >> >> power-domains: >> - maxItems: 1 >> + minItems: 0 > It cannot be 0. > > minItems: 1 > > Anyway you still need to restrict it per variant, as I said in previous > version.
Hm.. I'm not entirely sure what you mean.. Should I add a list of compatibles that are allowed to have 3 power-domains and leave it as it was before in the 'else' case?
Konrad
> > Best regards, > Krzysztof >
| |