Messages in this thread | | | From | Chaitanya Kulkarni <> | Subject | Re: [PATCH V2 4/7] null_blk: don't use magic numbers in the code | Date | Tue, 15 Nov 2022 03:49:35 +0000 |
| |
On 11/14/22 16:40, Bart Van Assche wrote: > On 10/5/22 20:18, Chaitanya Kulkarni wrote: >> Insteasd of using the hardcoded value use meaningful macro for tag > > Insteasd -> Instead? > >> available value of -1U in get_tag() and __alloc_cmd(). >> >> While at it return early on error to get rid of the extra indentation >> in __alloc_cmd(). > > Thanks, > > Bart. >
thanks for your comment Bart, I'll send out V3 with fixes..
-ck
| |