Messages in this thread | | | Date | Mon, 14 Nov 2022 09:04:08 +0100 | From | Miquel Raynal <> | Subject | Re: [PATCH] mtd: lpddr2_nvm: i2c: mux: reg: Fix possible null-ptr-deref |
| |
Hi Hui,
tanghui20@huawei.com wrote on Mon, 14 Nov 2022 10:01:41 +0800:
> It will cause null-ptr-deref when resource_size(add_range) invoked, > if platform_get_resource() returns NULL. > > Fixes: 96ba9dd65788 ("mtd: lpddr: add driver for LPDDR2-NVM PCM memories") > Signed-off-by: Hui Tang <tanghui20@huawei.com> > --- > drivers/mtd/lpddr/lpddr2_nvm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mtd/lpddr/lpddr2_nvm.c b/drivers/mtd/lpddr/lpddr2_nvm.c > index 367e2d906de0..cf8e86eb4b2c 100644 > --- a/drivers/mtd/lpddr/lpddr2_nvm.c > +++ b/drivers/mtd/lpddr/lpddr2_nvm.c > @@ -433,6 +433,8 @@ static int lpddr2_nvm_probe(struct platform_device *pdev) > > /* lpddr2_nvm address range */ > add_range = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (IS_ERR(add_range))
platform_get_resource() just returns NULL upon error.
> + return -ENODEV; > > /* Populate map_info data structure */ > *map = (struct map_info) {
Thanks, Miquèl
| |