Messages in this thread | | | Date | Mon, 14 Nov 2022 14:49:17 -0800 | From | Jaegeuk Kim <> | Subject | Re: [PATCH] f2fs: remove submit label in __submit_discard_cmd() |
| |
On 11/12, Yangtao Li wrote: > Complaint from Matthew Wilcox in another similar place: > > "submit? You don't submit anything at the 'submit' label. > it should be called 'skip' or something. But I think this > is just badly written and you don't need a goto at all." > > Let's remove submit label for readability. > > Signed-off-by: Yangtao Li <frank.li@vivo.com> > --- > fs/f2fs/segment.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index 3654c30e0517..0a72e787c585 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -1144,13 +1144,11 @@ static int __submit_discard_cmd(struct f2fs_sb_info *sbi, > if (time_to_inject(sbi, FAULT_DISCARD)) { > f2fs_show_injection_info(sbi, FAULT_DISCARD); > err = -EIO; > - goto submit; > - } > - err = __blkdev_issue_discard(bdev, > + } else > + err = __blkdev_issue_discard(bdev, > SECTOR_FROM_BLOCK(start), > SECTOR_FROM_BLOCK(len), > GFP_NOFS, &bio);
Thanks. I added {} to meet the coding style.
> -submit: > if (err) { > spin_lock_irqsave(&dc->lock, flags); > if (dc->state == D_PARTIAL) > -- > 2.25.1
| |