lkml.org 
[lkml]   [2022]   [Nov]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 2/7] vdpa/mlx5: Fix wrong mac address deletion
    On Sun, Nov 13, 2022 at 9:45 PM Eli Cohen <elic@nvidia.com> wrote:
    >
    > Delete the old MAC from the table and not the new one which is not there
    > yet.
    >
    > Fixes: baf2ad3f6a98 ("vdpa/mlx5: Add RX MAC VLAN filter support")
    > Signed-off-by: Eli Cohen <elic@nvidia.com>

    Acked-by: Jason Wang <jasowang@redhat.com>

    > ---
    > drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
    > index ea95081eca0c..c54d5088ed4f 100644
    > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
    > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
    > @@ -1686,7 +1686,7 @@ static virtio_net_ctrl_ack handle_ctrl_mac(struct mlx5_vdpa_dev *mvdev, u8 cmd)
    >
    > /* Need recreate the flow table entry, so that the packet could forward back
    > */
    > - mac_vlan_del(ndev, ndev->config.mac, 0, false);
    > + mac_vlan_del(ndev, mac_back, 0, false);
    >
    > if (mac_vlan_add(ndev, ndev->config.mac, 0, false)) {
    > mlx5_vdpa_warn(mvdev, "failed to insert forward rules, try to restore\n");
    > --
    > 2.38.1
    >

    \
     
     \ /
      Last update: 2022-11-14 05:42    [W:8.725 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site