Messages in this thread | | | Date | Mon, 14 Nov 2022 10:18:14 +0800 | From | Xu Yilun <> | Subject | Re: [PATCH 10/12] mfd: intel-m10-bmc: Add PMCI driver |
| |
On 2022-11-11 at 15:16:42 +0200, Ilpo Järvinen wrote: > On Fri, 11 Nov 2022, Xu Yilun wrote: > > On 2022-11-08 at 16:43:03 +0200, Ilpo Järvinen wrote: > > > > +static int pmci_probe(struct dfl_device *ddev) > > > +{ > > > + struct device *dev = &ddev->dev; > > > + struct pmci_device *pmci; > > > + > > > + pmci = devm_kzalloc(dev, sizeof(*pmci), GFP_KERNEL); > > > + if (!pmci) > > > + return -ENOMEM; > > > + > > > + pmci->m10bmc.dev = dev; > > > + pmci->dev = dev; > > > > I don't see its usage. > > It's used by dev_err() in patch 11/12.
I see. But is m10bmc.dev already good enough for the usage?
Thanks, Yilun
| |