Messages in this thread | | | Date | Sat, 12 Nov 2022 21:11:10 +0300 | Subject | Re: [PATCH -next v2 2/2] fs/ntfs3: Eliminate unnecessary ternary operator in ntfs_d_compare() | From | Konstantin Komarov <> |
| |
On 10/5/22 02:23, Nathan Chancellor wrote: > 'a == b ? 0 : 1' is logically equivalent to 'a != b'. > > Suggested-by: Nick Desaulniers <ndesaulniers@google.com> > Signed-off-by: Nathan Chancellor <nathan@kernel.org> > --- > > v2: New patch. > > fs/ntfs3/namei.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ntfs3/namei.c b/fs/ntfs3/namei.c > index 5d3a6ce3f05f..6b0d2c01d6ff 100644 > --- a/fs/ntfs3/namei.c > +++ b/fs/ntfs3/namei.c > @@ -432,7 +432,7 @@ static int ntfs_d_compare(const struct dentry *dentry, unsigned int len1, > /* First try fast implementation. */ > for (;;) { > if (!lm--) > - return len1 == len2 ? 0 : 1; > + return len1 != len2; > > if ((c1 = *n1++) == (c2 = *n2++)) > continue;
Thank you for your work, applied! First patch was already applied.
| |