Messages in this thread | | | Date | Sat, 12 Nov 2022 09:18:22 +0300 | Subject | Re: [PATCH 6/6] phy: qcom-qmp-combo: clean up common initialisation | From | Dmitry Baryshkov <> |
| |
On 11/11/2022 11:42, Johan Hovold wrote: > Commit 52e013d0bffa ("phy: qcom-qmp: Add support for DP in USB3+DP combo > phy") added support for the DisplayPort part of QMP PHYs but > unfortunately did so by duplicating parts of the shared configuration, > something which has lead to subtle bugs depending on probe order. > > As the resources have always been requested based on the USB > configuration, make sure to not rely on fields from the DP configuration > when using them (e.g. in case they get out of sync) and remove the now > unused fields from the DP configurations. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 47 ++--------------------- > 1 file changed, 4 insertions(+), 43 deletions(-)
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
-- With best wishes Dmitry
| |