Messages in this thread | | | Date | Fri, 11 Nov 2022 16:38:04 +0000 | Subject | Re: [PATCH v2] ASoC: codecs: wsa883x: use correct header file | From | Srinivas Kandagatla <> |
| |
On 08/11/2022 00:18, Randy Dunlap wrote: > Fix build errors when GPIOLIB is not set/enabled: > > ../sound/soc/codecs/wsa883x.c: In function 'wsa883x_probe': > ../sound/soc/codecs/wsa883x.c:1394:25: error: implicit declaration of function 'devm_gpiod_get_optional'; did you mean 'devm_regulator_get_optional'? [-Werror=implicit-function-declaration] > wsa883x->sd_n = devm_gpiod_get_optional(&pdev->dev, "powerdown", > ../sound/soc/codecs/wsa883x.c:1395:49: error: 'GPIOD_FLAGS_BIT_NONEXCLUSIVE' undeclared (first use in this function) > GPIOD_FLAGS_BIT_NONEXCLUSIVE); > ../sound/soc/codecs/wsa883x.c:1414:9: error: implicit declaration of function 'gpiod_direction_output'; did you mean 'gpio_direction_output'? [-Werror=implicit-function-declaration] > gpiod_direction_output(wsa883x->sd_n, 1); > > Fixes: 43b8c7dc85a1 ("ASoC: codecs: add wsa883x amplifier support") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Reported-by: kernel test robot <lkp@intel.com> > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Cc: Banajit Goswami <bgoswami@quicinc.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: Liam Girdwood <lgirdwood@gmail.com> > Cc: alsa-devel@alsa-project.org > Cc: Jaroslav Kysela <perex@perex.cz> > Cc: Takashi Iwai <tiwai@suse.com> > ---
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> v2: add the correct header file instead of messing with GPIOLIB in Kconfig > > sound/soc/codecs/wsa883x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -- a/sound/soc/codecs/wsa883x.c b/sound/soc/codecs/wsa883x.c > --- a/sound/soc/codecs/wsa883x.c > +++ b/sound/soc/codecs/wsa883x.c > @@ -7,7 +7,7 @@ > #include <linux/debugfs.h> > #include <linux/delay.h> > #include <linux/device.h> > -#include <linux/gpio.h> > +#include <linux/gpio/consumer.h> > #include <linux/init.h> > #include <linux/kernel.h> > #include <linux/module.h>
| |