Messages in this thread | | | Date | Fri, 11 Nov 2022 08:25:51 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH 0/4] cpumask: improve on cpumask_local_spread() locality |
| |
On Thu, 10 Nov 2022 20:00:23 -0800 Yury Norov wrote: > cpumask_local_spread() currently checks local node for presence of i'th > CPU, and then if it finds nothing makes a flat search among all non-local > CPUs. We can do it better by checking CPUs per NUMA hops.
Nice.
> This series is inspired by Valentin Schneider's "net/mlx5e: Improve remote > NUMA preferences used for the IRQ affinity hints" > > https://patchwork.kernel.org/project/netdevbpf/patch/20220728191203.4055-3-tariqt@nvidia.com/ > > According to Valentin's measurements, for mlx5e: > > Bottleneck in RX side is released, reached linerate (~1.8x speedup). > ~30% less cpu util on TX. > > This patch makes cpumask_local_spread() traversing CPUs based on NUMA > distance, just as well, and I expect comparabale improvement for its > users, as in Valentin's case. > > I tested it on my VM with the following NUMA configuration:
nit: the authorship is a bit more complicated, it'd be good to mention Tariq. Both for the code and attribution of the testing / measurements.
| |