Messages in this thread | | | Date | Fri, 11 Nov 2022 16:03:35 +0100 | From | Thomas Bogendoerfer <> | Subject | Re: [PATCH] MIPS: fix duplicate definitions for exported symbols |
| |
On Wed, Nov 02, 2022 at 08:27:39PM +0800, Rongwei Zhang wrote: > Building with clang-14 fails with: > > AS arch/mips/kernel/relocate_kernel.o > <unknown>:0: error: symbol 'kexec_args' is already defined > <unknown>:0: error: symbol 'secondary_kexec_args' is already defined > <unknown>:0: error: symbol 'kexec_start_address' is already defined > <unknown>:0: error: symbol 'kexec_indirection_page' is already defined > <unknown>:0: error: symbol 'relocate_new_kernel_size' is already defined > > It turns out EXPORT defined in asm/asm.h expands to a symbol definition, > so there is no need to define these symbols again. Remove duplicated > symbol definitions. > > Fixes: 7aa1c8f47e7e ("MIPS: kdump: Add support") > Signed-off-by: Rongwei Zhang <pudh4418@gmail.com> > --- > arch/mips/kernel/relocate_kernel.S | 15 +++++---------- > 1 file changed, 5 insertions(+), 10 deletions(-)
applied to mips-fixes.
Thomas.
-- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
| |